Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid class state by passing relevant config to PodReflector on instanciation #672

Merged
merged 1 commit into from Nov 10, 2022
Merged

Avoid class state by passing relevant config to PodReflector on instanciation #672

merged 1 commit into from Nov 10, 2022

Conversation

dolfinus
Copy link
Contributor

Based on this discussion:
#654 (comment)

@dolfinus dolfinus mentioned this pull request Nov 10, 2022
Merged
@consideRatio consideRatio reopened this Nov 10, 2022
@consideRatio
Copy link
Member

Thanks @dolfinus!! Retriggereing tests to run against main branch after merged #654

@consideRatio consideRatio changed the title Do not mess with PodReflector.labels class var Avoid class state by passing relevant config to PodReflector on instanciation Nov 10, 2022
@consideRatio consideRatio merged commit c6bb2a1 into jupyterhub:main Nov 10, 2022
@dolfinus dolfinus deleted the reflector_label branch November 10, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dolfinus @consideRatio