Binder badge: use repo.full_name #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actor is the user that opened the PR, but this may not be the same as the owner of the fork. `pull_request.head.repo.full_name` should be the `owner/reponame` of the PR fork
|
@hamelsmu does this look correct to you? |
|
Yeah this looks good to me |
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actor is the user that opened the PR, but this may not be the same as the owner of the fork. For example if you open a PR using an org branch, or if you open a PR using someone else's fork.
pull_request.head.repo.full_nameshould be theowner/reponameof the PR fork.E.g. Compare the first (old workflow) and last (updated workflow) comments on manicstreetpreacher/test-binder-badge#1