Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile.md #241

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Update dockerfile.md #241

merged 1 commit into from
Sep 15, 2021

Conversation

vaibhavsagar
Copy link
Contributor

It seems that mybinder.org is now launching jupyter-lab instead of jupyter-notebook. I've updated the documentation to reflect this.

It seems that `mybinder.org` is now launching `jupyter-lab` instead of `jupyter-notebook`. I've updated the documentation to reflect this.
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is correct - will leave open for a little bit to see if others have thoughts

@betatim
Copy link
Member

betatim commented Sep 15, 2021

Thanks for helping to keep the docs up to date. Did you try running the example docker run ... commands?

@betatim betatim merged commit 27cddff into jupyterhub:master Sep 15, 2021
@vaibhavsagar
Copy link
Contributor Author

Not while making the PR, but I ran into this separately: IHaskell/IHaskell#1278.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants