Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R tests are failing on main #1109

Closed
manics opened this issue Jan 8, 2022 · 7 comments
Closed

R tests are failing on main #1109

manics opened this issue Jan 8, 2022 · 7 comments

Comments

@manics
Copy link
Member

manics commented Jan 8, 2022

Bug description

I merged #1104 followed by #1107, and in combination the tests are failing.... in hindsight I should've closed/reopened #1107 before merging to trigger an updated CI check.

@yuvipanda Do you want to have a look? Or shall we revert #1107 since it's the most recent PR so that CI is green and fix it later?

@yuvipanda
Copy link
Collaborator

Yep, let's revert that for now? I'll look on Monday

Thanks for catching these!

@manics
Copy link
Member Author

manics commented Jan 8, 2022

I opened a PR to revert #1107 (#1110) but the tests on that PR are failing so maybe there's a problem in #1104, even though the tests were definitely passing before I merged it? 😢

I'll leave things as they are for now.

@yuvipanda
Copy link
Collaborator

I can't seem to reproduce this locally unfortunately...

@yuvipanda
Copy link
Collaborator

Could be my cache, busting it now. Taking a while, haha :)

@yuvipanda
Copy link
Collaborator

@manics it looks like a transient MRAN outage. I re-ran the tests on main and it passed now.

@yuvipanda
Copy link
Collaborator

@manics this PR also passes: #1110. I suspect it was an MRAN outage.

@manics
Copy link
Member Author

manics commented Jan 10, 2022

Good thing you're replacing MRAN 😁

@manics manics closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants