Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeze with mamba, add 3.9 #1017

Merged
merged 5 commits into from Mar 3, 2021
Merged

freeze with mamba, add 3.9 #1017

merged 5 commits into from Mar 3, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 18, 2021

  • use mamba to install in freeze.py to save time
  • add 3.9 to frozen environment list
  • bump notebook, nbconvert, jupyterhub-singleuser to current

@minrk
refreeze with mamba, add 3.9 to freeze list
5a32cc4
@minrk
bump notebook, nbconvert, jupyterhub
67cc5f7 
- jupyterhub-singleuser==1.3.0
- nbconvert==6.0.7
- notebook==6.2.0
@minrk minrk requested a review from manics February 19, 2021 09:40
manics
manics reviewed Feb 19, 2021
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switch to mamba looks good! I had a couple of inline queries about some of the dependency changes.

repo2docker/buildpacks/conda/environment.frozen.yml Outdated Show resolved Hide resolved
repo2docker/buildpacks/conda/environment.py-2.7.frozen.yml Show resolved Hide resolved
@minrk
refreeze
246d99c 
adds 3.9 environment
@minrk
freeze with strict channel priority
907c6f3 
avoids pulling in newer releases from defaults

this is conda's default behavior, but not mamba's
@minrk
refreeze with strict channel priority
b73c96e 
make sure we don't get any packages from 'defaults'
@minrk minrk requested a review from manics March 3, 2021 08:52
manics
manics approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it'd be good to have some sanity checks in the script to check for package removals or downgrades, but that can be discussed separately.

@manics manics merged commit d24d7e4 into jupyterhub:master Mar 3, 2021
@minrk minrk deleted the 39 branch March 3, 2021 10:06
@henchbot henchbot mentioned this pull request Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minrk @manics