Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unindent lines to fix the bug in "Specify certificate through Secret resource" #1755

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

salvis2
Copy link
Contributor

@salvis2 salvis2 commented Aug 24, 2020

Ran the local doc development instructions to make sure the tabbing looked correct, and it does.

Closes #1750 .

@welcome
Copy link

welcome bot commented Aug 24, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

Thanks @salvis2 !

@consideRatio consideRatio merged commit 152c8c5 into jupyterhub:master Aug 25, 2020
@welcome
Copy link

welcome bot commented Aug 25, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio
Copy link
Member

consideRatio commented Aug 25, 2020

Wieee congrats on the first PR! :D Very welcome!! 🎉 ❤️

@salvis2
Copy link
Contributor Author

salvis2 commented Aug 25, 2020

Wieee congrats on the first PR! :D Very welcome!! 🎉 ❤️

Thanks! Hopefully more to come as I continue learning!

@salvis2 salvis2 deleted the security-doc-bug branch September 10, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify certificate through Secret resource Documentation Bug
2 participants