Added config prePuller.pullProfileListImages #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/prePuller-config-to-exclude-pulling-profileList-images
branch
from
efce54c
to
68b3324
Compare
With a large list of images in the singleuser.profileList, users ended up with delays caused by images being pulled for so long time that it blocked what was actually important to pull to get started properly. This option allows for a long singleuser.profileList with many different images to be setup, while only pulling the default image, or optionally those configured under prePuller.extraImages.
It seems smarter to pull the images that are most likeley to be needed first, and that includes singleuser.extraContainers.
consideRatio
force-pushed
the
pr/prePuller-config-to-exclude-pulling-profileList-images
branch
from
68b3324
to
fefa941
Compare
This was referenced Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a large list of images in the singleuser.profileList, users ended
up with delays caused by images being pulled for so long time that it
blocked what was actually important to pull to get started properly.
This option allows for a long singleuser.profileList with many different
images to be setup, while only pulling the default image, or optionally
those configured under prePuller.extraImages.
Closes #1393, Closes #1739 good enough
I also added a commit optimizing the order slightly, where the more likely to be used images are pulled first, in this case i determined that images in singleuser.extraContainers are far more likeley to be used than an image in a profileList