Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: let dependabot update jupyterhub, replace JUPYTERHUB_VERSION with PIP_OVERRIDES #1948

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Dec 17, 2020

I wanted to make dependabot also manage the jupyterhub version. To make that happen, I had to stop pinning it explicitly here and there.

Associated with this in the PR, is a removal of the JUPYTERHUB_VERSION --build-args. I added PIP_OVERRIDES instead as it would be more generally helpful.

Action points

  • Improve inline docs of chartpress.yaml so that users understand how to learn more etc if they inspect it.
  • Help users make use of the new PIP_OVERRIDES argument by commenting in chartpress.yaml

@consideRatio consideRatio added this to the 0.11.0 milestone Dec 21, 2020
@consideRatio
Copy link
Member Author

consideRatio commented Dec 21, 2020

I assigned this the 0.11.0 milestone as I'd like to use this opportunity to try if the automation works with a JupyterHub 1.3.0 bump which I want to be in the 0.11.0 release of the chart.

I'm also self-merging this after some self-review for a second time. I compromise on the review part to improve on the progress part.

@consideRatio consideRatio merged commit 7d18aaf into jupyterhub:master Dec 21, 2020
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Dec 21, 2020
jupyterhub/zero-to-jupyterhub-k8s#1948 Merge pull request #1948 from consideRatio/pr/let-dependabot-update-jupyterhub
@consideRatio
Copy link
Member Author

It worked as it should, but I found that we have strict test to match the singleuser-sample version against the hub version, so we should also bump the singleuser-sample version preferably with dependabot. It probably needs to be two separate dependabot setups, but thats okay.

#1959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant