New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: hub image ubuntu->debian, py38->py39, build-essential
removed, --build-arg PIP_OVERRIDES=...
removed, images/hub/dependencies removed
#2733
Merged
yuvipanda
merged 5 commits into
jupyterhub:main
from
consideRatio:pr/test-python-3.9-slim-bullseye-image
May 31, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/test-python-3.9-slim-bullseye-image
branch
from
May 29, 2022 12:08
3405428
to
9b5135b
Compare
consideRatio
changed the title
breaking, maint: trial python39-slim-bullseye as hub base image
breaking, maint: python39-slim-bullseye as hub base image
May 29, 2022
consideRatio
force-pushed
the
pr/test-python-3.9-slim-bullseye-image
branch
from
May 29, 2022 14:41
07ac375
to
5193268
Compare
consideRatio
force-pushed
the
pr/test-python-3.9-slim-bullseye-image
branch
from
May 29, 2022 15:16
5193268
to
fa81c67
Compare
consideRatio
changed the title
breaking, maint: python39-slim-bullseye as hub base image
breaking: hub image ubuntu->debian, May 29, 2022
build-essential
removed, --build-arg PIP_OVERRIDES=...
removed, images/hub/dependencies removed
consideRatio
requested review from
minrk,
manics and
yuvipanda
and removed request for
minrk and
manics
May 29, 2022 15:23
minrk
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
yay! I also appreciate the addition of tini. |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 31, 2022
jupyterhub/zero-to-jupyterhub-k8s#2733 Merge pull request #2733 from consideRatio/pr/test-python-3.9-slim-bullseye-image
consideRatio
changed the title
breaking: hub image ubuntu->debian,
breaking: hub image ubuntu->debian, py38->py39, Jun 3, 2022
build-essential
removed, --build-arg PIP_OVERRIDES=...
removed, images/hub/dependencies removedbuild-essential
removed, --build-arg PIP_OVERRIDES=...
removed, images/hub/dependencies removed
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've trialed a switch from
ubuntu:20.04
topython:3.9-slim-bullseye
and think this is a breaking change we should do. Closes #2731. Some of the changes in this PR are changes that could be done withubuntu:20.04
as well.Image size
Using
dive
:About removed apt packages
libpq-dev
doesn't have to be installed any more as there is a pip wheel for aarch64 now making it not needed.build-essential
isn't needed, but removing it makes people who install packages later that requiregcc
etc need to install it.python3*
is removed as the base image provides python for us.About pycurl apt package dependencies
It seems that we can get openssl as a backend for
pycurl
(introduced in #1185) by referencinglibcurl4
without needing to installlibssl-dev
andlibcurl4-openssl-dev
.If I test to run
python -c "import pycurl; print(pycurl.version_info())"
in the 1.2.0 image and compare with the output from this new Dockerfile we see this.About removed --build-arg
PIP_OVERRIDES
This was introduced by me in #1948. I think it should be removed now. We have requirements.txt to allow anyone pin whatever version if the repo is cloned the repo, and at worst someone would have to do a
sed
replace operation to the in the requirements.txt file or append a line if they have automation to make their own build of the hub image.Above removed
images/hub/dependencies
scriptThis script was removed for binderhub in jupyterhub/binderhub#1433, but not for z2jh because of how we passed
--build-arg
withPIP_OVERRIDES
something we stopped with.The script is no longer needed, but instead we can simply do this and we are done. This script works both locally and in a GitHub CI environment as well, which makes us able to use automation to update this.