ci: add another upgrade test and provide a template rendering diff #1978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1923 it became very relevant to inspect the changes in rendered helm templates. The helm diff plugin can provide a diff compared to an already installed helm chart, so in other words it is only sensible to add as part of the upgrade tests, diffing from the installed version and the version to be installed.
In this PR I add another upgrade tests, so instead of just going from the latest stable release, we try to upgrade also from the latest dev release. By upgrading from the latest dev release we can also smoothly inject a
helm diff
first that provides us with the specific details on what changed in the Helm template rendered output of this PR.While this is a good start, I'm not sure about what happens if the PR isn't recently rebased. Will it then also show removal of added parts in the helm diff? I guess it comes down to how the checkout action works, does it checkout the exact state of the PR, or the state of the repo after PR would be merged?