Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add another upgrade test and provide a template rendering diff #1978

Merged

Conversation

consideRatio
Copy link
Member

Working on #1923 it became very relevant to inspect the changes in rendered helm templates. The helm diff plugin can provide a diff compared to an already installed helm chart, so in other words it is only sensible to add as part of the upgrade tests, diffing from the installed version and the version to be installed.

In this PR I add another upgrade tests, so instead of just going from the latest stable release, we try to upgrade also from the latest dev release. By upgrading from the latest dev release we can also smoothly inject a helm diff first that provides us with the specific details on what changed in the Helm template rendered output of this PR.

While this is a good start, I'm not sure about what happens if the PR isn't recently rebased. Will it then also show removal of added parts in the helm diff? I guess it comes down to how the checkout action works, does it checkout the exact state of the PR, or the state of the repo after PR would be merged?

@manics
Copy link
Member

manics commented Jan 9, 2021

The pull_request test will run against the PR merged into the upstream branch at the time the PR was last updated irrespective of whether the PR's base is up to date or not. This is why if there's an old PR it's often useful to close and re-open the PR to force an updated test run before merging in case upstream changes have invalidated the PR.

The branch status only looks at the branch. This is why it's useful to have both triggers in a workflow, as well as allowing tests to run without opening a PR you can also see if it passes on a branch but fails on the PR or vice-versa, indicating there's a mismatch somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants