Remove deprecated user-scheduler config #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/remove-old-user-scheduler
branch
from
f849c59
to
514ac6f
Compare
consideRatio
changed the title
consideRatio
changed the title
consideRatio
force-pushed
the
pr/remove-old-user-scheduler
branch
from
514ac6f
to
264c019
Compare
consideRatio
force-pushed
the
pr/remove-old-user-scheduler
branch
from
264c019
to
8da2683
Compare
consideRatio
force-pushed
the
pr/remove-old-user-scheduler
branch
from
8da2683
to
1cec8bd
Compare
1 task
consideRatio
force-pushed
the
pr/remove-old-user-scheduler
branch
from
1cec8bd
to
f366eda
Compare
|
This LGTM after a month, I'll go for the merge. |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 17, 2021
jupyterhub/zero-to-jupyterhub-k8s#1995 Merge pull request #1995 from consideRatio/pr/remove-old-user-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have maintained two separate versions of how we configure the user-scheduler, one for k8s 1.16 and below, and one for k8s 1.17 and above. This is because the version of kube-scheduler required us to do so.
With #2005 merged, we can now drop the <=1.16 version of how we configure kube-scheduler to become our user-scheduler and only debug / focus on the new configuration.