Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imagePullSecret.enabled to work alongside imagePullSecret.create #2038

Merged

Conversation

consideRatio
Copy link
Member

imagePullSecret.create were to be the new .enabled which should still work, but it turns out that I've missed one entry making .create function while .enabled wouldn't function.

@consideRatio
Copy link
Member Author

Actually hmmm... schema.yaml doesn't represent .create / .enabled properly yet.

I'm considering removing the .enabled alias and forcing users to transform their config to have .create instead of .enabled to reduce the complexity.

I think it would be quite messy to implement a check for either enabled or create based on my brief experience of jsonschema. Anyone knows how to do that nicely?

imagePullSecret:
type: object
required: [create]
if:
properties:
create:
const: true
then:
required: [registry, username, password]

@consideRatio
Copy link
Member Author

Actually hmmm... schema.yaml doesn't represent .create / .enabled properly yet.

Well, this isn't a real problem. It won't raise an issue for the user if the user has used .enabled instead of .create.

@consideRatio consideRatio merged commit 1aa133a into jupyterhub:master Feb 19, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Feb 19, 2021
jupyterhub/zero-to-jupyterhub-k8s#2038 Merge pull request #2038 from consideRatio/pr/fix-imagepullsecret.enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant