Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hub pod to manage k8s Secrets/Services for KubeSpawner.internal_ssl #2065

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

thomasv314
Copy link

@thomasv314 thomasv314 commented Feb 24, 2021

Closes #2064

@welcome
Copy link

welcome bot commented Feb 24, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

consideRatio commented Feb 24, 2021

@thomasv314 please provide a clear description as to why you think the hub container should be allowed to do this.

Ah... Perhaps the next kubespawner version will require it. At least k8s Secrets. But Services?

@consideRatio consideRatio changed the title Allow hub container to delete secrets/services Allow hub pod to manage k8s Secrets/Services for KubeSpawner.internal_ssl Feb 24, 2021
@consideRatio consideRatio merged commit 764fd9a into jupyterhub:master Feb 24, 2021
@welcome
Copy link

welcome bot commented Feb 24, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Feb 24, 2021
@consideRatio
Copy link
Member

consideRatio commented Feb 24, 2021

Thanks @thomasv314 for the pioneering efforts! If you find this was or wasn't enough to support internal_ssl please let me know!

Version 0.11.1-n239.h10196f66 now contains this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kubespawner internal_ssl
2 participants