hub image: add sqlalchemy-cocroachdb dependency #2262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on jupyterhub's docs, it should be generally compatible with any sqlalchemy provider.
In our environment, we're relying on cocroachdb due to easier clusterization and scalability.
Aside from a tiny defect in jupyterhub (jupyterhub/jupyterhub#3484, it was not part of 1.4.1), which might not even be specific to cocroachdb (rather to the dummy authenticator), everything seems to work well.
Currently, we have to dynamically install
sqlalchemy-cockroachdb
upon container start. It'd be great to have it included in the base image.P.S. If I got it right, I had to run the
dependencies freeze --upgrade
script to make sure all dependencies are added to the requirements.txt. That's why you can see two files updated instead of just one (requirements.in).