Transition to use pre-commit hook in jupyterhub/chartpress #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was causing trouble for us as it couldn't be automatically installed with `helm` as a dependency from where it was defined. Due to this and the fact that I believe `helm lint` captures very few errors and that we have a CI check for this and more already, I figure it is better we just remove it because otherwise we can't use the pre-commit.ci service.
consideRatio
force-pushed
the
pr/use-external-chartpress-pre-commit-hook
branch
from
a53f798
to
d7c9065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops using a locally defined pre-commit hook to run chartpress that also assumes
chartpresshas been installed ahead of time. By instead using a remotely defined pre-commit hook in jupyterhub/chartpress#127,chartpresswill be automatically be installed by pre-commit which enables us to not crash trying to use the pre-commit.ci service.After fixing this, I learned that the helmlint pre-commit hook also fail in the pre-commit.ci service because
helmisn't getting installed but is assumed. Due to this, I simply opted to drop the helmlint hook instead. It is a trade off of course, but I feel a bit committed to trying out the pre-commit.ci service now and I don't think runninghelm lintas part of pre-commit is so important, it doesn't capture much errors I would say.