Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug if z2jh is used as a dependency with an alias #2310

Merged
merged 1 commit into from Jul 13, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jul 13, 2021

If z2jh was used as a dependency helm chart, and it had an alias, this bug would happen which make template rendering fail.

As an example, the following Chart.yaml would cause an error.

apiVersion: v2
description: irrelevant
name: irrelevant
version: 0.1.0
dependencies:
  - name: jupyterhub
    version: "1.0.1"
    repository: "https://jupyterhub.github.io/helm-chart"
    alias: dep-chart-alias
executing "jupyterhub.fullname" at <.Values.jupyterhub.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride

@consideRatio consideRatio merged commit 53e2182 into jupyterhub:main Jul 13, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant