Skip to content

fix: bug if z2jh is used as a dependency with an alias#2310

Merged
consideRatio merged 1 commit into
jupyterhub:mainfrom
consideRatio:pr/fix-alias-bug
Jul 13, 2021
Merged

fix: bug if z2jh is used as a dependency with an alias#2310
consideRatio merged 1 commit into
jupyterhub:mainfrom
consideRatio:pr/fix-alias-bug

Conversation

@consideRatio

@consideRatio consideRatio commented Jul 13, 2021

Copy link
Copy Markdown
Member

If z2jh was used as a dependency helm chart, and it had an alias, this bug would happen which make template rendering fail.

As an example, the following Chart.yaml would cause an error.

apiVersion: v2
description: irrelevant
name: irrelevant
version: 0.1.0
dependencies:
  - name: jupyterhub
    version: "1.0.1"
    repository: "https://jupyterhub.github.io/helm-chart"
    alias: dep-chart-alias
executing "jupyterhub.fullname" at <.Values.jupyterhub.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride

@consideRatio consideRatio merged commit 53e2182 into jupyterhub:main Jul 13, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant