Fix bugs related to installing chart multiple times in the same namespace #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
HoseonRyu
changed the title
consideRatio
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Mar 15, 2023
jupyterhub/zero-to-jupyterhub-k8s#3032 Merge pull request #3032 from HoseonRyu/fix-alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
I wanna create multi-hub for many users.
I'm trying to use an alias for this, and found out that it is supported with following PR.
fix: bug if z2jh is used as a dependency with an alias
However, I found some problems with it, and made this PR to fix it.
Environments
Problem 1 - existing-secret
Like this PR,
existing-secretshould also be in the conditional statement.Problem 2 - proxy service selector
After solving Problem 1, I succeeded in creating two hubs (each have different urls in
ingress.hosts)There is a bug that when spawning through one url, it randomly spawns in another hub
When I spawn singleuser via one url, other hub spawns randomly.
To prevent this, a selector was added to the proxy.