Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fetch stable/dev releases using helm show to avoid cache issues #3256

Merged
merged 2 commits into from Nov 1, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 22, 2023

  • ci: fetch stable/dev releases using helm show to avoid cache issues

Previously we fetched the latest stable and dev release from metadata we
have maintained, but doing that and then using helm install of that
version made us use two sources of data, where one could be relatively
outdated due to hitting a cache while the other may not.

Using helm show, we rely on the helm chart repository website
returning a index.yaml listing versions etc both when checking whats the
latest versions, and when installing - like that we avoid a cache issue
I think.

  • ci: cleanup unused sourcing of ci/common

Sibling PR to jupyterhub/binderhub#1785

Previously we fetched the latest stable and dev release from metadata we
have maintained, but doing that and then using `helm install` of that
version made us use two sources of data, where one could be relatively
outdated due to hitting a cache while the other may not.

Using `helm show`, we rely on the helm chart repository website
returning a index.yaml listing versions etc both when checking whats the
latest versions, and when installing - like that we avoid a cache issue
I think.
@consideRatio consideRatio merged commit af1e276 into jupyterhub:main Nov 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant