Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fetch stable/dev releases using helm show to avoid cache issues #3256

Merged
merged 2 commits into from
Nov 1, 2023
Merged

ci: fetch stable/dev releases using helm show to avoid cache issues #3256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feccd75
ci: fetch stable/dev releases using helm show to avoid cache issues
consideRatio Oct 22, 2023
4060b6a
ci: cleanup unused sourcing of ci/common
consideRatio Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/test-chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,16 @@ jobs:
- name: "(Upgrade) Install ${{ matrix.upgrade-from }} chart"
if: matrix.test == 'upgrade'
run: |
. ./ci/common
if [ ${{ matrix.upgrade-from }} = stable -o ${{ matrix.upgrade-from }} = dev ]; then
UPGRADE_FROM_VERSION=$(curl -sSL https://hub.jupyter.org/helm-chart/info.json | jq -er '.jupyterhub.${{ matrix.upgrade-from }}')
# NOTE: We change the directory so jupyterhub the chart name won't be
# misunderstood as the local folder name.
#
# https://github.com/helm/helm/issues/9244
cd ci

if [ ${{ matrix.upgrade-from }} = stable ]; then
UPGRADE_FROM_VERSION=$(helm show chart --repo=https://hub.jupyter.org/helm-chart/ jupyterhub | yq e '.version' -)
elif [ ${{ matrix.upgrade-from }} = dev ]; then
UPGRADE_FROM_VERSION=$(helm show chart --devel --repo=https://hub.jupyter.org/helm-chart/ jupyterhub | yq e '.version' -)
else
UPGRADE_FROM_VERSION=${{ matrix.upgrade-from }}
fi
Expand All @@ -289,11 +296,6 @@ jobs:
echo ""
echo "Installing already released jupyterhub version $UPGRADE_FROM_VERSION"

# FIXME: We change the directory so jupyterhub the chart name won't be
# misunderstood as the local folder name.
#
# https://github.com/helm/helm/issues/9244
cd ci
helm install jupyterhub --repo https://hub.jupyter.org/helm-chart/ jupyterhub --values ../dev-config.yaml --version=$UPGRADE_FROM_VERSION ${{ matrix.upgrade-from-extra-args }}

- name: "(Upgrade) Install helm diff"
Expand Down