Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending an empty message results in a silent server error #800

Closed
krassowski opened this issue May 22, 2024 · 1 comment · Fixed by #946
Closed

Sending an empty message results in a silent server error #800

krassowski opened this issue May 22, 2024 · 1 comment · Fixed by #946
Labels
bug Something isn't working
Milestone

Comments

@krassowski
Copy link
Member

Description

Sending empty message:

  • (a) is possible despite the send button being greyed out
  • (b) results in an error on the server side:
Task exception was never retrieved
future: <Task finished name='Task-21794' coro=<RootChatHandler._route() done, defined at jupyter-ai/packages/jupyter-ai/jupyter_ai/handlers.py:220> exception=IndexError('list index out of range')>
Traceback (most recent call last):
  File "jupyter-ai/packages/jupyter-ai/jupyter_ai/handlers.py", line 224, in _route
    maybe_command = message.body.split(None, 1)[0]
IndexError: list index out of range

Reproduce

Go to chat and press Enter

Expected behavior

  • It is not possible to send empty message
  • There is not server-side error

Context

  • JupyterLab version: 4.2.0
  • Extension 4.16.0
@krassowski krassowski added the bug Something isn't working label May 22, 2024
@dlqqq dlqqq added this to the Priority milestone May 31, 2024
@dlqqq
Copy link
Member

dlqqq commented May 31, 2024

@krassowski I just noticed this as well! I suspect that this was caused by some regression in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants