New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for checkout #831

Open

fcollonval opened this issue Nov 26, 2020 · 0 comments

Labels

Member

fcollonval commented Nov 26, 2020

@ianhi Thanks a lot for the quick fix.

Would you have time to add unit tests on this feature and the one addressed by #824 to reduce potential troubles in the future?

it would make sense to put them in https://github.com/jupyterlab/jupyterlab-git/blob/master/tests/model.spec.tsx#L299. I think you could assert internal calls using spy like https://github.com/jupyterlab/jupyterlab-git/blob/master/tests/model.spec.tsx#L365.

Originally posted by @fcollonval in #829 (comment)

fcollonval added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment