adding more writable checks

jupyterlab · Sep 19, 2018 · 11e1c83 · jasongrout · Sep 24, 2018 · ivanov
1 parent 9256af3
commit 11e1c83
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/packages/docmanager-extension/src/index.ts b/packages/docmanager-extension/src/index.ts
@@ -522,13 +522,23 @@ function addCommands(
     isEnabled: () => {
       const iterator = shell.widgets('main');
       let widget = iterator.next();
+      let anyWritable = false;
       while (widget) {
         if (docManager.contextForWidget(widget)) {
-          return true;
+          let context = docManager.contextForWidget(widget);
+          if (
+            context &&
+            context.contentsModel &&
+            context.contentsModel.writable
+          ) {
+            anyWritable = true;
+          }
         }
         widget = iterator.next();
       }
-      return false;
+      // disable saveAll if all of the widgets models
+      // have writable === false
+      return anyWritable;
     },
     execute: () => {
       const iterator = shell.widgets('main');

diff --git a/packages/notebook/src/default-toolbar.ts b/packages/notebook/src/default-toolbar.ts
@@ -85,7 +85,8 @@ export namespace ToolbarItems {
           }
         });
       },
-      tooltip: 'Save the notebook contents and create checkpoint'
+      tooltip: 'Save the notebook contents and create checkpoint',
+      enabled: panel.context.contentsModel.writable
     });
   }