-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialogs have unreadable colour of links in dark mode #14084
Labels
Milestone
Comments
@krassowski Hi! I have a university break starting from next week and I'd love to contribute. When can I get started, and what exactly do I have to do? |
@AdityaGirdhar no need to ask for permission - feel free to start right away (we do not assign "good first issues") - please just read our contributing documentation and open a draft PR when ready. |
This was referenced Mar 5, 2023
JasonWeill
pushed a commit
that referenced
this issue
Mar 27, 2023
* Fix button color on About JupyterLab * Fix text color on documentation link * Update .jp-Button-flat styling Remove color property (should be defined in packages > help-extension > style > base.css) Remove on hover property changes Remove on focus background color change * Update .jp-Button-flat styling Modified styling to conditionally output color based on theme Displays #FF9800 (orange) in dark mode Displays #0D4781 (blue) in light mode Ensured colors pass WebAIM contrast guidelines * Remove hover color change on dialog content links * Adjust content link color This fixes the color contrast for .jp-Dialog-content a, as well as any other elements using jp-content-link-color in light theme * Simplify CSS selectors for performance Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Simplify CSS selectors for performance Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update .jp-Button-flat styling Removed dark theme conditional styling Changed color var to content-link-color to achieve consistent blue links --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Description
Relevant code parts were touched in #11827
The problem here is that
.jp-Dialog-content a:hover
has higher precedence.Reproduce
for the other one go to Help menu → About
Expected behavior
var(--jp-content-link-color)
by default:hover
Context
The text was updated successfully, but these errors were encountered: