-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scroll bars white in dark theme #3008
Comments
Which OS and browser combination is this? This is going to be very
challenging to address as some OS (Mac) automatically adjust the scrollbars
based on the background color. If we move to explicit styling, we lose that.
…On Mon, Sep 18, 2017 at 8:16 PM, Tyler Drobbin ***@***.***> wrote:
Not a major issue by any means, but I've been using the dark theme a bunch
at night time and notice that the scroll bars, vertical and horizontal, are
white.
I think it would look better if they were greyed, or blacked to be more
consistent with the dark theme.
In the below, you can see the scroll bars to the right of the two open
notebooks, and at the bottom of the input cells in the notebook on the
right.
Thanks!
[image: screen shot 2017-09-18 at 11 09 53 pm]
<https://user-images.githubusercontent.com/16639439/30574314-1053fd92-9cc7-11e7-8f4a-aafa882012e9.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3008>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0Cs13GnAbwU6EuC0ag1DinXAY6ADks5sjzIWgaJpZM4PbzLH>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com
|
Ah, I see. Yes - I'm on macOS 10.12.5 and chrome 60.0.3112.113. Personally, I would be perfectly fine with overriding the default scroll styling. Is the issue also potentially overriding scrolls on plugins and visualizations from other packages? |
Only Chrome allows for custom styling of native browser scrollbars. |
OK, good to know - thanks for all the info. |
Maybe an option to just "visually" hide the scrollbars. Users that turn this option on probably know that there are "scrollbars" they can use anyway. |
This issue was fixed a while ago with an option to style the scrollbars. Look in the Settings menu, under the JupyterLab Theme submenu, and make sure "Theme Scrollbars" is checked. |
Fixed in #6026. |
Oh, didn't notice that one. Thank you very much :) |
Not a major issue by any means, but I've been using the dark theme a bunch at night time and notice that the scroll bars, vertical and horizontal, are white.
I think it would look better if they were greyed, or blacked to be more consistent with the dark theme.
In the below, you can see the scroll bars to the right of the two open notebooks, and at the bottom of the input cells in the notebook on the right.
Thanks!
The text was updated successfully, but these errors were encountered: