Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll bars white in dark theme #3008

Closed
tdrobbin opened this issue Sep 19, 2017 · 8 comments
Closed

scroll bars white in dark theme #3008

tdrobbin opened this issue Sep 19, 2017 · 8 comments
Labels
pkg:application question status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone

Comments

@tdrobbin
Copy link

Not a major issue by any means, but I've been using the dark theme a bunch at night time and notice that the scroll bars, vertical and horizontal, are white.

I think it would look better if they were greyed, or blacked to be more consistent with the dark theme.

In the below, you can see the scroll bars to the right of the two open notebooks, and at the bottom of the input cells in the notebook on the right.

Thanks!

screen shot 2017-09-18 at 11 09 53 pm

@ellisonbg
Copy link
Contributor

ellisonbg commented Sep 19, 2017 via email

@tdrobbin
Copy link
Author

Ah, I see. Yes - I'm on macOS 10.12.5 and chrome 60.0.3112.113.

Personally, I would be perfectly fine with overriding the default scroll styling. Is the issue also potentially overriding scrolls on plugins and visualizations from other packages?

@sccolbert
Copy link
Contributor

sccolbert commented Sep 19, 2017

Only Chrome allows for custom styling of native browser scrollbars.

@tdrobbin
Copy link
Author

OK, good to know - thanks for all the info.

@sleighsoft
Copy link

Maybe an option to just "visually" hide the scrollbars. Users that turn this option on probably know that there are "scrollbars" they can use anyway.

@jasongrout
Copy link
Contributor

This issue was fixed a while ago with an option to style the scrollbars. Look in the Settings menu, under the JupyterLab Theme submenu, and make sure "Theme Scrollbars" is checked.

@jasongrout
Copy link
Contributor

Fixed in #6026.

@jasongrout jasongrout modified the milestones: Future, 1.0 Sep 16, 2019
@sleighsoft
Copy link

Oh, didn't notice that one. Thank you very much :)

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application question status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

No branches or pull requests

6 participants