Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all kernel messages are handled async and in order #4188

Closed
jasongrout opened this issue Mar 15, 2018 · 0 comments · Fixed by #4697
Closed

Verify all kernel messages are handled async and in order #4188

jasongrout opened this issue Mar 15, 2018 · 0 comments · Fixed by #4697
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

Continuing from #3884, we should verify that all kernel messages are handled in order. Since at least some messages are handled async, all messages should be handled async. From the other issue:

In the classic notebook kernel, we took care that every kernel message handling function could return a promise all the way up the chain to the basic kernel message handling loop, and the kernel would not start handling the next message until the previous message was handled.

For example, the comm message handler should be able to pass back a promise, and kernel message handling doesn't proceed until that promise is fulfilled or rejected.

@jasongrout jasongrout added this to the 1.0 milestone Mar 15, 2018
@jasongrout jasongrout modified the milestones: 1.0, Beta 3 Apr 27, 2018
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 8, 2018
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 8, 2018
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 12, 2018
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 12, 2018
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant