Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file loader escape hatches should test basename #4406

Closed
jasongrout opened this issue Apr 17, 2018 · 1 comment · Fixed by #5709
Closed

file loader escape hatches should test basename #4406

jasongrout opened this issue Apr 17, 2018 · 1 comment · Fixed by #5709

Comments

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 17, 2018

#3743 should have tested against the basename of the file, rather than just the start of the string in the webpack configs. That would allow for relative imports, etc.

Something like

      { test: p => path.basename(p).startsWith('JUPYTERLAB_RAW_LOADER_'), use: 'raw-loader' },
      { test: p => path.basename(p).startsWith('JUPYTERLAB_URL_LOADER_'), use: 'url-loader?limit=10000' },
      { test: p => path.basename(p).startsWith('JUPYTERLAB_FILE_LOADER_'), use: 'file-loader' },
@jasongrout jasongrout added this to the Beta 3 milestone Apr 17, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Apr 18, 2018

I'm getting tired of these huge prefixes, though. Perhaps better would be some metadata in the package.json signifying which files should be loaded with raw, url, or file loaders, like jupyterlab.loaders.raw = ['list', 'of', 'files'].

@jasongrout jasongrout self-assigned this Apr 18, 2018
@jasongrout jasongrout removed this from the Beta 3 milestone Apr 18, 2018
@jasongrout jasongrout added this to the Beta 2 Patch milestone Apr 18, 2018
@jasongrout jasongrout removed this from the Minor release milestone Apr 28, 2018
@jasongrout jasongrout added this to the Beta 3 milestone Apr 28, 2018
@jasongrout jasongrout removed this from the Beta 3 milestone Jun 27, 2018
@jasongrout jasongrout added this to the Beta 4 milestone Jun 27, 2018
@blink1073 blink1073 assigned blink1073 and unassigned jasongrout Aug 13, 2018
@blink1073 blink1073 removed this from the 0.34 milestone Aug 15, 2018
@blink1073 blink1073 added this to the 0.35 milestone Aug 15, 2018
@blink1073 blink1073 removed this from the 0.35 milestone Sep 5, 2018
@blink1073 blink1073 added this to the 1.0 milestone Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants