Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeMirror file editor does not respect font size Settings value #7909

Closed
AlbertHilb opened this issue Feb 22, 2020 · 0 comments · Fixed by #7910
Closed

CodeMirror file editor does not respect font size Settings value #7909

AlbertHilb opened this issue Feb 22, 2020 · 0 comments · Fixed by #7910
Labels
bug pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@AlbertHilb
Copy link
Contributor

Reproduce

  1. Open Settings,
  2. go to text editor section,
  3. modify font size value,
  4. save Settings,
  5. the file editor font size does not change.

Expected behavior

File editor font size should respect the new value in Settings.

Regards
@AlbertHilb AlbertHilb mentioned this issue Feb 22, 2020
Merged
telamonian added a commit that referenced this issue Feb 24, 2020
@telamonian
Merge pull request #7910 from AlbertHilb/FontSizeIssue
ec932f8 
CodeMirror font size setting issue (#7909)
@ikiw ikiw mentioned this issue Feb 24, 2020
Merged
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
@ikiw ikiw mentioned this issue Feb 24, 2020
Open
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

CodeMirror font size setting issue (#7909) AlbertHilb/jupyterlab
2 participants
@jasongrout @AlbertHilb