Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal command palette doesn't respond to mouse clicks on a command #9121

Closed
nmichaud opened this issue Oct 1, 2020 · 2 comments · Fixed by #9210
Closed

Modal command palette doesn't respond to mouse clicks on a command #9121

nmichaud opened this issue Oct 1, 2020 · 2 comments · Fixed by #9210
Assignees
@ellisonbg @afshin @jasongrout
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
3.0

Comments

@nmichaud
Copy link
Contributor

nmichaud commented Oct 1, 2020 •
edited
Loading

The modal command palette doesn't let you select commands using the mouse (the click event seems to be ignored).

Reproduce

  1. Bring up modal command palette (Cmd-Shift-C)
  2. Click on first option ("New Console" in my case)
  3. Nothing happens and command palette is closed

Expected behavior

Command is executed

Context

  • Operating System and version: OS X 10.12
  • Browser and version: Chrome 85.0.4183.121
  • JupyterLab version: 3.0.0rc2
@ellisonbg
Copy link
Contributor

Ohh, good catch!

@ellisonbg ellisonbg added this to the 3.0 milestone Oct 8, 2020
@ellisonbg ellisonbg added the bug label Oct 8, 2020
@jasongrout jasongrout mentioned this issue Oct 21, 2020
Closed
43 tasks
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Oct 22, 2020
@jasongrout
Only reset command palette if focus is shifting outside of the palette.
e240328 
This uses the same ideas from our dialog box to have natural behavior in clicking in and outside of the palette.

Fixes jupyterlab#9121
@jasongrout jasongrout mentioned this issue Oct 22, 2020
Merged
@jasongrout
Copy link
Contributor

Fixed in #9210

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ellisonbg ellisonbg

@afshin afshin

@jasongrout jasongrout

Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix focus issues with command palette jasongrout/jupyterlab
4 participants
@ellisonbg @afshin @jasongrout @nmichaud