Federated labextensions: package name logic #9320
Labels
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
Description
When using the federated labextension script, the logic for finding the package name fails if the directory contains e.g. a
docs
directory that is a valid Python module.find_packages
will find thedocs
module and look for the_jupyter_labextension_paths
function there.https://github.com/jupyterlab/jupyterlab/blob/master/jupyterlab/federated_labextensions.py#L373-L381
Reproduce
docs
directory that contains an__init__.py
file in the extensionjupyter labextension develop .
in the root directory of the extensionExpected behavior
If I can suggest a slight change in the current logic, it looks to me that the
package = find_packages()[0]
could be more of a "fallback" solution for when thesetup.py --name
is not defined, instead of the other way around.I can come up with a PR myself if this change would be ok:
setup.py --name
find_packages()[0]
Context
Troubleshoot Output
Command Line Output
Browser Output
The text was updated successfully, but these errors were encountered: