Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize cell source \r line endings #11271

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

jasongrout
Copy link
Contributor

References

Fixes #10941

Code changes

Normalize \r cell line endings to \n.

User-facing changes

We also change the bug report message in the js console to clearly indicate that if the user pastes data into the issue, it will include the text or code of their editor. This helps prevent users sharing code unwittingly.

Backwards-incompatible changes

We do not want to encourage people to blindly paste their code into a public issue. This modifies the message to help them be more aware that they will be sharing their code publicly.
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added the tag:Backport This PR is slated to be backported after it is merged. label Oct 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 6200 <- [7955 - 8503 - 8939] -> 9213 3900 <- [4020 - 4261 - 4374] -> 4572
expected 6938 <- [7584 - 7618 - 7760] -> 8204 3461 <- [3524 - 3534 - 3590] -> 4136
switch-from
chromium
actual 442 <- [485 - 498 - 523] -> 565 307 <- [314 - 327 - 354] -> 378
expected 464 <- [480 - 489 - 499] -> 789 310 <- [338 - 344 - 352] -> 370
switch-to
chromium
actual 1747 <- [1815 - 1861 - 1874] -> 1936 1510 <- [1550 - 1572 - 1607] -> 1702
expected 1706 <- [1730 - 1764 - 1814] -> 2015 1541 <- [1549 - 1562 - 1574] -> 1608
close
chromium
actual 6125 <- [14638 - 15877 - 17096] -> 19965 3677 <- [4070 - 4348 - 4510] -> 5055
expected 5176 <- [5770 - 10533 - 14493] -> 18824 3325 <- [3691 - 3890 - 3939] -> 4073

❗ Test metadata have changed
--- /dev/fd/63	2021-10-09 00:34:40.633123968 +0000
+++ /dev/fd/62	2021-10-09 00:34:40.633123968 +0000
@@ -8,33 +8,33 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v3",
+      "brand": "Xeon® Platinum 8171M",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 524288,
-        "l3": 31457280
+        "l2": 2097152,
+        "l3": 36700160
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "63",
+      "model": "85",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.4,
+      "speed": 2.6,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "2",
+      "stepping": "4",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7291699200
+      "total": 7291695104
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "6c19bc2f6263432da3d31804b6f46a17",
+      "serial": "0f5fd491ff264b5f9d56e03599b4fae0",
       "servicepack": "",
       "uefi": false
     }

@blink1073 blink1073 modified the milestones: 3.1.x, 3.2.x Oct 11, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit f07934a into jupyterlab:master Oct 11, 2021
@blink1073
Copy link
Contributor

@meeseeksdev please backport to 3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Oct 11, 2021
blink1073 pushed a commit that referenced this pull request Oct 11, 2021
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
@blink1073 blink1073 added the bug label Oct 14, 2021
@meeseeksmachine
Copy link
Contributor

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/code-editor-out-of-sync-after-using-sublime-text/11217/21

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:cells pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Backport This PR is slated to be backported after it is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Editor out of Sync
3 participants