Make password inputs not give away how many characters were typed #12659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with classic Jupyter Notebook behavior, and is generally a good security idea. Also, this decouples the implementation of the HTML input widget and the notion of the input being a password input by storing the password field as a private attribute of the stdin control, rather than relying on how the input was created.
|
Thanks for making a pull request to jupyterlab! |
fcollonval
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Thanks @jasongrout
CI failure is due to flaky test and is unrelated.
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
|
@meeseeksdev please backport to 3.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 8, 2022
…many characters were typed
fcollonval
pushed a commit
that referenced
this pull request
Jun 8, 2022
…cters were typed (#12668) Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
hbcarlos
pushed a commit
to hbcarlos/jupyterlab
that referenced
this pull request
Jun 10, 2022
…pyterlab#12659) This aligns with classic Jupyter Notebook behavior, and is generally a good security idea. Also, this decouples the implementation of the HTML input widget and the notion of the input being a password input by storing the password field as a private attribute of the stdin control, rather than relying on how the input was created.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Adjusts the original password input implementation from #517 to not give away how many characters were typed.
Code changes
Make password inputs not give away how many characters were typed
This aligns with classic Jupyter Notebook behavior (always show 8 dots), and is generally a good security idea.
Also, this decouples the implementation of the HTML input widget and the notion of the input being a password input by storing the password field as a private attribute of the stdin control, rather than relying on how the input was created.
User-facing changes
Always show 8 dots as the value of the password input
Backwards-incompatible changes