Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make password inputs not give away how many characters were typed #12659

Merged
merged 1 commit into from Jun 8, 2022
Merged

Make password inputs not give away how many characters were typed #12659

merged 1 commit into from Jun 8, 2022

Commits on Jun 7, 2022

  1. Make password inputs not give away how many characters were typed 

    This aligns with classic Jupyter Notebook behavior, and is generally a good security idea.

Also, this decouples the implementation of the HTML input widget and the notion of the input being a password input by storing the password field as a private attribute of the stdin control, rather than relying on how the input was created.
    @jasongrout
    jasongrout committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    bc99c48 View commit details
    Browse the repository at this point in the history