Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create environment for every PR using Uffizzi #13699

Closed
wants to merge 1 commit into from

Conversation

daramayis
Copy link

This PR is a part of #13629 and helps demonstrate Uffizzi integration with Jupyterlab.

This will help create preview environments on all of Jupyterlab Pull Requests and help contributors including the maintainers iterate faster on their PRs.
I have created a PR over daramayis#1 (comment) to show what it looks like to have a preview environment deployed against your PR.

You can check out the preview over here as well.

@waveywaves

@jupyterlab-probot
Copy link

Thanks for making a pull request to f-jupyterlab!
To try out this branch on binder, follow this link: Binder

@welcome
Copy link

welcome bot commented Jan 3, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@daramayis
Copy link
Author

Hi @JasonWeill 👋

Any thoughts on the PR? how is it looking :)

Thank you.

@jasongrout
Copy link
Contributor

Thanks, this indeed looks very fast and nice.

On the service side, https://www.uffizzi.com/pricing indicates that if we started using this in this open source project, we'd have unlimited concurrent previews, etc.? Is that right?

@daramayis
Copy link
Author

daramayis commented Jan 5, 2023

@jasongrout yes, that's right — the project will have unlimited concurrent previews.

@jasongrout
Copy link
Contributor

@daramayis - someone pointed out that when I go to the PR review at https://pr-1-deployment-10033-f-jupyterlab.app.uffizzi.com/lab, I see artifacts from a previous person trying it out. This is concerning for two reasons:

  1. The other person trying things out may affect the state of things so that a review is not a true clean fresh copy of the PR
  2. It's a vector for someone to be malicious - someone could embed something malicious in the preview that is not visible in the actual PR

I'd love to hear your thoughts about how the PR previews preserve state across multiple people accessing them.

@daramayis daramayis force-pushed the uffizzi branch 8 times, most recently from d176b3b to 1caa278 Compare January 11, 2023 10:09
@daramayis
Copy link
Author

daramayis commented Jan 11, 2023

Hi @jasongrout.

Thank you for the review — I have updated the PR regarding password protection.

So we have a feature for protecting the preview environments.
The preview environment is a single instance, in the scope of PR — also u can re-trigger the pipeline for deploy a new one.
You can set up the credentials and share them with the internal team.

So I set some testing credentials(secrets) in my repository to demonstrate how it looks like and works.

Testing

Please open https://app.uffizzi.com/github.com/daramayis/f-jupyterlab/pull/1
user: admin
pass: demodemo

@daramayis
Copy link
Author

Hey @jasongrout,

Friendly ping — do you have a timeline for looking at this?

Thank you.

@daramayis
Copy link
Author

Hey @jasongrout,

Nothing hears, we are closing the PR.

@daramayis daramayis closed this Feb 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants