New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create environment for every PR using Uffizzi #13699
Conversation
Thanks for making a pull request to f-jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
Hi @JasonWeill 👋 Any thoughts on the PR? how is it looking :) Thank you. |
Thanks, this indeed looks very fast and nice. On the service side, https://www.uffizzi.com/pricing indicates that if we started using this in this open source project, we'd have unlimited concurrent previews, etc.? Is that right? |
@jasongrout yes, that's right — the project will have unlimited concurrent previews. |
@daramayis - someone pointed out that when I go to the PR review at https://pr-1-deployment-10033-f-jupyterlab.app.uffizzi.com/lab, I see artifacts from a previous person trying it out. This is concerning for two reasons:
I'd love to hear your thoughts about how the PR previews preserve state across multiple people accessing them. |
d176b3b
to
1caa278
Compare
Hi @jasongrout. Thank you for the review — I have updated the PR regarding password protection. So we have a feature for protecting the preview environments. So I set some testing credentials(secrets) in my repository to demonstrate how it looks like and works. TestingPlease open https://app.uffizzi.com/github.com/daramayis/f-jupyterlab/pull/1 |
Hey @jasongrout, Friendly ping — do you have a timeline for looking at this? Thank you. |
Hey @jasongrout, Nothing hears, we are closing the PR. |
This PR is a part of #13629 and helps demonstrate Uffizzi integration with Jupyterlab.
This will help create preview environments on all of Jupyterlab Pull Requests and help contributors including the maintainers iterate faster on their PRs.
I have created a PR over daramayis#1 (comment) to show what it looks like to have a preview environment deployed against your PR.
You can check out the preview over here as well.
@waveywaves