Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to MathJax 3 [with git history] #13877

Merged
merged 126 commits into from
Mar 16, 2023
Merged

upgrade to MathJax 3 [with git history] #13877

merged 126 commits into from
Mar 16, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Jan 28, 2023

References

Code changes

  • Bumps MathJax version to 3
  • Ports existing labextension from jupyter-renderers/mathjax3-extension while preserving git history.
  • Removes packages/mathjax2{,-extension} and adds packages/mathjax-extension.

User-facing changes

Screen Shot 2023-01-25 at 4 21 53 PM

Screen Shot 2023-01-25 at 4 28 28 PM

Bugs

  • JL4 regression: MathJax context menu options (e.g. "Scale 1.5x") no longer work. Recommend this gets addressed in a follow-up PR.

Backwards-incompatible changes

None known.

jasongrout and others added 30 commits July 31, 2018 10:32
@jasongrout @ian-r-rose
Initial version of a MathJax 3 (alpha) extension.
4ad8422
@jasongrout @ian-r-rose
add tex options for inline math
0a4d5d5
@ian-r-rose
Address runtime errors.
9d3c9f0
@ian-r-rose
Workaround to force rerender upon calling typeset().
38488e8
@jasongrout @ian-r-rose
Make new mathjax data structures for every render.
8cbe9af
@jasongrout @ian-r-rose
Construct the mathjax document once, but clear it every time.
a1a4207
@jasongrout @ian-r-rose
Delete unnecessary setting of the document.
8e0eb4c
@ian-r-rose
Update JupyterLab version.
41f8034
@ian-r-rose
Add ability to auto-generate font css.
0290e54
@ian-r-rose
Load MathJax fonts separately using the JupyterLab webpack.
8936296
@ian-r-rose
Fix dependencies.
f058ae4
@ian-r-rose
Bump version.
969bd89
@ian-r-rose
Updates for mathjax3-alpha4 and JupyterLab v0.32.
61078d9
@ian-r-rose
Bump mathjax again.
b6bddb1
@ian-r-rose
Update to JupyterLab 0.33 and MathJax3 beta 1
09d8159
@ian-r-rose
Bump versions.
9f639ba
@ian-r-rose
Update yarn.lock.
61eb08b
@ian-r-rose
Cleanup.
9dc147e
@ian-r-rose
Skip lib check.
1f0d12f
@ian-r-rose
Left align math in cell outputs for KaTeX and MathJax3 extensions.
78ac7e2
@ian-r-rose
Merge pull request jupyterlab#153 from ian-r-rose/left-align-outputs
1fa9309 
Left align math in cell outputs for KaTeX and MathJax3 extensions.
@blink1073
Compat with jlab 0.34
7ee3d32
@blink1073
Publish
5d80e08 
 - @jupyterlab/fasta-extension@0.17.2
 - @jupyterlab/geojson-extension@0.17.1
 - @jupyterlab/katex-extension@0.18.0
 - @jupyterlab/mathjax3-extension@0.2.0
 - @jupyterlab/plotly-extension@0.17.1
 - @jupyterlab/vega2-extension@0.17.1
 - @jupyterlab/vega3-extension@0.17.1
@blink1073
Merge pull request jupyterlab#154 from blink1073/jlab-34
c10d776 
Compat with jlab 0.34
@blink1073
Publish
cde6858 
 - @jupyterlab/katex-extension@0.18.1
 - @jupyterlab/mathjax3-extension@0.2.1
@jasongrout
Update for jupyterlab 0.35 prerelease
c3abe35 
From the update-dependency script in @jupyterlab/buildutils:

update-dependency.js --lerna --minimal --regex '^@jupyterlab/' ^next
@jasongrout
Update to jlab 0.35 final packages
ff962c1
@jasongrout
Update typescript to 3.1.1
e30cc4c
@blink1073
Merge pull request jupyterlab#162 from jasongrout/jlab35
d0acd75 
Update for JupyterLab 0.35
@blink1073
Publish
9212a3a 
 - @jupyterlab/fasta-extension@0.18.0
 - @jupyterlab/geojson-extension@0.18.0
 - @jupyterlab/katex-extension@0.19.0
 - @jupyterlab/mathjax3-extension@0.3.0
 - @jupyterlab/plotly-extension@0.18.0
 - @jupyterlab/vega2-extension@0.18.0
 - @jupyterlab/vega3-extension@0.18.0
@dlqqq
Copy link
Member Author

dlqqq commented Mar 15, 2023

CI failures all seem to be related to yarn install failing. @jtpio I need an interim release of @jupyterlab/mathjax-extension to get CI passing.

[LabBuildApp] yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
error Couldn't find any versions for "@jupyterlab/mathjax-extension" that matches "^4.0.0-alpha.21"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Other CI failures are due to upstream issues, e.g. server error from pre-commit.ci and failing visual regression tests on latest version of master.

@jtpio
Copy link
Member

jtpio commented Mar 15, 2023

nterim release of @jupyterlab/mathjax-extension to get CI passing.

Normally the package should already be published on npm (from the last time): https://www.npmjs.com/package/@jupyterlab/mathjax-extension

@dlqqq
Copy link
Member Author

dlqqq commented Mar 15, 2023

@jtpio The latest version published is 4.0.0-alpha.17, whereas this branch requires 4.0.0-alpha.21.

@jtpio
Copy link
Member

jtpio commented Mar 15, 2023

Right, I'll have a look and report here.

@jtpio
Copy link
Member

jtpio commented Mar 15, 2023

@dlqqq I just published a newer version and restarted the CI checks.

@fcollonval
Copy link
Member

bot please update snapshots

@github-actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions
Copy link
Contributor

Galata snapshots updated.

fcollonval
fcollonval approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dlqqq

Merging as is to reduce burden - but we should solve the remaining points/issues before 4.0.0 final

@fcollonval
Copy link
Member

Remaining CI failures are not relevant

@fcollonval fcollonval closed this Mar 16, 2023
@fcollonval fcollonval reopened this Mar 16, 2023
@fcollonval fcollonval merged commit 7e5e8bb into jupyterlab:master Mar 16, 2023
@jtpio jtpio mentioned this pull request Mar 17, 2023
Merged
7 tasks
@jtpio jtpio mentioned this pull request Jun 5, 2023
Closed
This was referenced Aug 29, 2023
Open
Open
@jtpio jtpio mentioned this pull request Oct 5, 2023
Merged
9 tasks
@kno10 kno10 mentioned this pull request Nov 5, 2023
Open
@jmshea
Copy link

jmshea commented Jan 5, 2024

Can anyone help me understand how to call MathJax methods now?

Background: My Python+Javascript library JupyterQuiz generates interactive quizzes that can include LaTeX, but I need to call the appropriate method to tell MathJax to typeset the LaTeX code, because it is loaded by Javascript. For MathJax 3, the usual way to do this to to pass the element to MathJax.typeset(), but the MathJax global object in JupyterLab 4+ does not have the appropriate methods -- it still looks like the pre-loading version of the MathJax object.

Reference: From the MathJax 3 docs: "The global variable MathJax is used to store the configuration for MathJax. Once MathJax is loaded, however, MathJax changes the MathJax variable to contain the various methods needed to control MathJax."

It seems that the MathJax variable never gets updated in JupyterLab 4.

Any help would be greatly appreciated!

@krassowski
Copy link
Member

@jmshea folks usually don't look at comments on closed PRs so I would suggest that you open a new issue instead, please.

@agriyakhetarpal agriyakhetarpal mentioned this pull request Apr 24, 2024
Closed
This was referenced Aug 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

@krassowski krassowski krassowski left review comments

@fcollonval fcollonval fcollonval approved these changes

Assignees

@dlqqq dlqqq

Labels
api-change A change that should be accompanied by a major version increase Design System CSS documentation maintenance pkg:extensionmanager pkg:mathjax2 tag:CSS For general CSS related issues and pecadilloes tag:Examples tag:Testing
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Update to MathJax 3
10 participants
@dlqqq @krassowski @jtpio @fcollonval @jmshea @jasongrout @ian-r-rose @blink1073 @gnestor @bsdz