Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Workspaces GUI #15946

Merged
merged 30 commits into from
Mar 25, 2024
Merged

Implement Workspaces GUI #15946

merged 30 commits into from
Mar 25, 2024

Commits on Mar 7, 2024

  1. Refactor workspaces to provide a scaffold for Workspaces UI 

    Fixup versions
    @krassowski
    krassowski committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4d6529e View commit details
    Browse the repository at this point in the history

  2. Remove workspace commands from top-level file menu

    @krassowski
    krassowski committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    672544c View commit details
    Browse the repository at this point in the history

  3. Implement workspaces sidebar and menu implementation 

    Fix sidebars and commands missing await

Add the menus and sidebars schema

Fixup integrity

Fix yarn lock

Fix margin around close buttons in sidebar
    @krassowski
    krassowski committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8fcd1f6 View commit details
    Browse the repository at this point in the history

  4. Add workspaces docs to a dedicated file, add GUI stub

    @krassowski
    krassowski committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8b5812c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Add unit tests for WorkspacesModel

    @krassowski
    krassowski committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    95ac8b3 View commit details
    Browse the repository at this point in the history

  2. Implement validation of workspace names, cleanup

    @krassowski
    krassowski committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    efec5c6 View commit details
    Browse the repository at this point in the history

  3. Add documentation snapshot which tests opening 

    workspace from file, adding workspaces by command, and context menu.
Fix minor issue with docs formatting/linking.
    @krassowski
    krassowski committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c9135f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. .jupyterlab-workspace files do not need licence headers

    @krassowski
    krassowski committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    7926120 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge remote-tracking branch 'upstream/main' into workspace-manager

    @krassowski
    krassowski committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4f90990 View commit details
    Browse the repository at this point in the history

  2. Fix tests, update snapshots

    @krassowski
    krassowski committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    da2711e View commit details
    Browse the repository at this point in the history

  3. Fix sidebar test by fixing workspaces state mock implementation 

    Wait for launcher to avoid flaky snapshot

Add snapshot for sidebar
    @krassowski
    krassowski committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    0de7c37 View commit details
    Browse the repository at this point in the history

  4. Test workspaces menu 

    Add snapshot for workspaces submenu
    @krassowski
    krassowski committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    5dc0a2e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Lint: add missing brackets

    @krassowski
    krassowski committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    10a7d38 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'main' into workspace-manager

    @krassowski
    krassowski committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    bcf8dfc View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Add workspace name in the "Delete" tooltip

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    19f3ad8 View commit details
    Browse the repository at this point in the history

  2. Adjust use of ellipsis (…) in workspace commands/menu

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2872d00 View commit details
    Browse the repository at this point in the history

  3. Add quotes to emphasize workspace name, 

    to avoid confusion when workspace is named with a word
    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f15ed80 View commit details
    Browse the repository at this point in the history

  4. Add note that deleting all workspaces is irreversible

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c257f6d View commit details
    Browse the repository at this point in the history

  5. Rename InputDialogTextualBase to InputDialogTextBase

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b934baa View commit details
    Browse the repository at this point in the history

  6. Add a note about characters allowed in workspace names.

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6459bc0 View commit details
    Browse the repository at this point in the history

  7. Add an example for workspace date/time format.

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8134d1f View commit details
    Browse the repository at this point in the history

  8. Apply suggestions on wording in workspaces docs 

    Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
    @krassowski @JasonWeill
    krassowski and JasonWeill committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3e90ce4 View commit details
    Browse the repository at this point in the history

  9. Fix snapshot (previous update got flaky kernel from another test)

    @krassowski
    krassowski committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3c867b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge remote-tracking branch 'upstream/main' into workspace-manager

    @krassowski
    krassowski committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    44da8ef View commit details
    Browse the repository at this point in the history

  2. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    098612e View commit details
    Browse the repository at this point in the history

  3. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    bcc4b77 View commit details
    Browse the repository at this point in the history

  4. Revert spurious snapshot updates

    @krassowski
    krassowski committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b602c1f View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Update the test workspace to account for the new "Recent Files" section

    @krassowski
    krassowski committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4dc6cfd View commit details
    Browse the repository at this point in the history

  2. Fix flaky snapshot

    @krassowski
    krassowski committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e7746e9 View commit details
    Browse the repository at this point in the history

  3. Update one more snapshot after merge

    @krassowski
    krassowski committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    fde83ee View commit details
    Browse the repository at this point in the history