Implement Workspaces GUI

[krassowski]

References

Closes #6944

Code changes

• adds dedicated workspaces and workspaces-extension packages
• moves existing workspace logic for "save", "save as" and "open" (and commands) from apputils-extension:workspaces (which retains only the mime extension for opening .jupyter-workspace files on click)
• adds workspaces-extension:sidebar plugin which populates the running sidebar with the workspaces as per mockups in Create a workspaces GUI #6944
• adds workspaces-extension:menu plugin which populates a "Workspaces..." submenu in the main "File" menu; the existing "Save Workspace" and "Save Workspace As..." menu entries are moved to this new sub-menu.
• adds workspaces-extension:commands plugin which implements all the new commands and adds them to the command palette
• improves dialog and file dialog APIs to enable implementation of dialogs from mockups in Create a workspaces GUI #6944

Other (less relevant) code changes

• simpliies saveAs logic by using InputDialog.getText() (which gives us pre-selection and placeholder)
• removes duplicated licence banner in filebrowser/style/base.css
• allows to set defaultButton on input dialogs; this is just passed to dialog which supports the defaultButton already

User-facing changes

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[JasonWeill]

@krassowski Thanks for your work so far on this! Please let me know when you'd like some feedback on it.

[krassowski]

Note to reviewers: failures of npm dependencies failed to install are expected because this PR adds a new package which is not on npm yet. These will get resolved once we merge and follow with a new pre-release.

[krassowski]

Done in 8134d1f.

[krassowski]

Done in 2872d00.

[krassowski]

Thank you for the review @JasonWeill!

The menu should use ellipses consistently. Apple's Human Interface Guidelines for menus suggest, "Append an ellipsis to a menu item’s label when people need to provide additional information before the action can complete." A cascading menu, like File > Workspaces, should not have an ellipsis (as it does now), but all of its submenu items require additional information in a modal dialog, so they should all have ellipses.

Done in 2872d00. What I was trying to do was being consistent with "Save and Export Notebook As..." just above which does have an ellipsis. Do you think that should be changed too (if so, let's open an issue to track it)?

In the running pane’s “Workspaces” section“, when I hover over the trash icon to the right of each workspace, the tooltip only says ”Delete“. For accessibility and usability, it should say ”Delete %1“, with the workspace name substituted in. (”Delete workspace ‘%1’“ could also work.)

Done in 19f3ad8.

The confirmation for deleting a workspace doesn’t put the name of the workspace in quotes or otherwise emphasize it, so users may miss it. This will also avoid confusion in case the workspace’s name is a word.

Done in f15ed80.

The first sentence of the confirmation dialog for deleting a workspace reads, “Deleting workspace %1 will also delete its URL.” I’m not sure what this means. The URL itself is not deleted, but visiting it will no longer take the user to workspace %1. Consider alternate wording, such as, “If you delete workspace ‘%1’, URLs that refer to this workspace will go to a different workspace.”

This wording was taken from mockups in #6944. While I agree that "deleting a URL" sounds odd, I do not think that "URLs that refer to this workspace will go to a different workspace" is accurate (it will not - it will either show an error dialog that workspace does not exist and load the default workspace, or create a new one; I have no idea why it sometimes does one or the other). I suggest to discuss this in #6944 and we can adjust it after this PR is merged (as it staying open has a high cost due to merge conflicts).

After I click a link to go to the auto-w workspace, when I open the running widget in the left pane, then I expand workspaces, language servers, kernels, and open tabs, in that order, I see “language servers” is very tall and empty, and both “kernels” and “workspaces” have content in them but are very small:

You can resize them by dragging. Changes to the logic for managing sizes of the panels is out of scope for this PR, but if you want to suggest a better behaviour I would advise to open a new issue.

The “Delete All” dialog needs work. Its title is in Title Case and ends in a question mark (Delete All?) whereas the dialog title for deleting a single workspace is in sentence case and has no punctuation (Delete workspace).

This comes from the running package code:

jupyterlab/packages/running/src/index.tsx

Lines 356 to 378 in a1166c1

	const shutdownAllLabel =
	options.manager.shutdownAllLabel || trans.__('Shut Down All');
	const shutdownTitle = `${shutdownAllLabel}?`;
	const shutdownAllConfirmationText =
	options.manager.shutdownAllConfirmationText ||
	`${shutdownAllLabel} ${options.manager.name}`;
	this.addClass(SECTION_CLASS);
	this.title.label = options.manager.name;
	function onShutdown() {
	void showDialog({
	title: shutdownTitle,
	body: shutdownAllConfirmationText,
	buttons: [
	Dialog.cancelButton(),
	Dialog.warnButton({ label: shutdownAllLabel })
	]
	}).then(result => {
	if (result.button.accept) {
	options.manager.shutdownAll();
	}
	});

Other dialogs, like those for shutting down all kernels or opening from an arbitrary path, use Title Case, and some end in a question mark.

Yes, because they all generated by running package code. I would suggest that changes to that are handled in separate follow up PR as these might lead to broader API changes, best discussed separately.

In addition, the “Delete All” dialog does not convey that deleting all workspaces is irreversible (cannot be undone), whereas the "Delete workspace" dialog does. I think that it’s important to convey that something cannot be undone as prominently as possible.

Done in c257f6d.

[JasonWeill]

Thanks for opening related issues! I think we're good to proceed now.

[krassowski]

bot please update snapshots

[github-actions]

Documentation snapshots updated.

[github-actions]

Galata snapshots updated.

[krassowski]

Note to self: one docs test needs work before merging:

    [documentation] › test/documentation/workspaces.test.ts:35:7 › Workspaces sidebar › Workspaces context menu 

[krassowski]

I'm planning to merge and cut a new pre-release early on Monday.