Last modified header for wide layouts #16207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
It looks like this modifies the snapshots. I would guess it is either because of changed thresholds or more likely because of the use of container queries. I would think implementing it by swapping |
|
@krassowski I don't see a provision to change the |
|
please update snapshots |
|
Documentation snapshots updated. |
|
Galata snapshots updated. |
This was referenced Apr 25, 2024
krassowski
reviewed
Apr 25, 2024
krassowski
reviewed
Apr 25, 2024
krassowski
approved these changes
Apr 25, 2024
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
* Revert "Alternate description for disabled filters" This reverts commit 059fb7e. * Revert "Revert "Alternate description for disabled filters"" This reverts commit 27ed1d0. * Uses longer title in larger modified columns * Updates timestamp format on initial render * Update width thresholds to avoid overlap * Uses container queries to show only a small or large modified header * Update Playwright Snapshots * Update Playwright Snapshots * Fix error in kernels sidebar when switching kernels, remove unused prop (jupyterlab#16188) * Do not crash if there are no sessions for kernel * Revert snapshot incorrectly updated in jupyterlab#16046 * Remove unused private `shutdownAllLabel` prop from `List` and `ListWidget` * Update Playwright Snapshots * Updates examples * Make `reateHeaderItemNodeWithSizes` private for now * Revert flaky snapshot updates --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16197.
Code changes
Adds a long "Last Modified" header. The longer header is used when the column is at least 300px wide, suitable for full-screen layouts such as those used in Notebook. The shorter "Modified" header is likely to be used in JupyterLab left panels.