Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rmtree errors #5400

Merged
merged 3 commits into from Sep 28, 2018
Merged

Handle rmtree errors #5400

merged 3 commits into from Sep 28, 2018

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 28, 2018

Fixes #5397

afshin
afshin approved these changes Sep 28, 2018
Copy link
Member

@afshin afshin left a comment

Thanks!

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 28, 2018

Looks like we were getting the same error yesterday, but it didn't cause the test to fail: https://ci.appveyor.com/project/jupyterlab/jupyterlab/build/1.0.9146/job/0cxe75c8wdoofwkg?fullLog=true#L1419

Perhaps us upgrading the build system now causes that test to fail?

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 28, 2018

And it looks like we're getting the same appveyor failure in other PRs, so it's not specific to this one.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 28, 2018

Looks good to me too.

@jasongrout jasongrout merged commit d3c50a5 into jupyterlab:master Sep 28, 2018
1 of 2 checks passed
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@blink1073 blink1073 deleted the fix-clean-windows branch Oct 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants