Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure node exists when traversing up the DOM tree. #6171

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Make sure node exists when traversing up the DOM tree. #6171

merged 1 commit into from
Apr 6, 2019

Conversation

afshin
Copy link
Member

@afshin afshin commented Apr 6, 2019

Simple null check when traversing up the DOM tree.

@afshin afshin added this to the 1.0 milestone Apr 6, 2019
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@afshin afshin self-assigned this Apr 6, 2019
ian-r-rose
ian-r-rose approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ian-r-rose ian-r-rose merged commit 46e04d3 into jupyterlab:master Apr 6, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasongrout jasongrout jasongrout approved these changes

@ian-r-rose ian-r-rose ian-r-rose approved these changes

Assignees

@afshin afshin

Labels
bug pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Pre-Release
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@afshin @jasongrout @ian-r-rose