Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notion of default search providers #6301

Merged
merged 1 commit into from May 2, 2019

Conversation

@aschlaep
Copy link
Member

@aschlaep aschlaep commented May 2, 2019

References

Fixes third point brought up in #6217 by @afshin

Code changes

This removes the notion of default search providers in the documentsearch package. Instead of importing and registering the default notebook and codemirror search providers directly in the constructor of the SearchProviderRegistry, the two default search provider implementations are imported by the documentsearch-extension package and registered there.

User-facing changes

There are no user facing or interface changes here.

Backwards-incompatible changes

None!

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 2, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@aschlaep aschlaep changed the title remove notion of default search providers Remove notion of default search providers May 2, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Nice!

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 2, 2019

And I'm really liking this PR template!

@blink1073 blink1073 merged commit 84d6eca into jupyterlab:master May 2, 2019
9 checks passed
@blink1073 blink1073 added this to the 1.0 milestone May 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants