Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension upgrade script #8950

Merged
merged 14 commits into from Sep 3, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 2, 2020

References

Fixes #8870
Fixes #8869
Relies on jupyterlab/jupyterlab_server#123

Code changes

  • Adds a script for extension authors python -m jupyterlab.upgrade_extension to automatically upgrade their scripts.
    They are prompted before files are overwritten.
  • Fixes handling of watch mode and makes watch mode easier for extension authors

User-facing changes

Easier for extension authors to upgrade their scripts.

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 3.0 milestone Sep 2, 2020
@blink1073 blink1073 added this to In progress in Extension System rework via automation Sep 2, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 changed the title Add extension upgrade script [WIP] Add extension upgrade script Sep 3, 2020
@blink1073
Copy link
Member Author

TODO: we need to move all handling of page_config to jupyterlab_server, so we get the latest page_config in the handler.

@blink1073
Copy link
Member Author

One more remaining TODO that I need to sync up with @Zsailer on today, otherwise this is entirely working for the upgraded example in jupyterlab/extension-examples#113 in watch mode.

@blink1073 blink1073 changed the title [WIP] Add extension upgrade script Add extension upgrade script Sep 3, 2020
@blink1073 blink1073 merged commit 1e82e0b into jupyterlab:master Sep 3, 2020
Extension System rework automation moved this from In progress to Done Sep 3, 2020
@blink1073
Copy link
Member Author

I am cutting a beta with this.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Extensions
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade helper for extensions Add watch handling for non-symlinked dynamic extensions
1 participant