Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of single-document mode switch in menu bar #9267

Merged
merged 1 commit into from Nov 3, 2020

Conversation

jasongrout
Copy link
Contributor

References

Code changes

User-facing changes

  • Make text centered in menu bar
  • transparent background matches menu bar (hover still shows background, similar to menu items)
  • use theme font color
  • switch thumb position now symmetric when on and off
  • switch position uses absolute positioning
  • switch slightly taller so margins are integer pixels

Before (on, off, hover):
Screen Shot 2020-11-03 at 12 21 11 AM
Screen Shot 2020-11-03 at 12 21 28 AM
Screen Shot 2020-11-03 at 12 21 45 AM

After (on, off, hover):
Screen Shot 2020-11-03 at 12 23 19 AM
Screen Shot 2020-11-03 at 12 22 55 AM
Screen Shot 2020-11-03 at 12 23 09 AM

Backwards-incompatible changes

- Make text centered in menu bar
- transparent background matches menu bar (hover still shows background, similar to menu items)
- switch thumb position now symmetric when on and off
- switch position uses absolute positioning
- switch slightly taller so margins are integer pixels
@jasongrout jasongrout added this to the 3.0 milestone Nov 3, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added Design System CSS pkg:application tag:CSS For general CSS related issues and pecadilloes labels Nov 3, 2020
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jtpio jtpio merged commit ba25b9a into jupyterlab:master Nov 3, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Design System CSS pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants