Do not error if requiredVersion is not provided.

[jasongrout]

References

Code changes

If a package overrides the sharing config for a dependency, it might have forgotton to give the requiredVersion (so requiredVersion is undefined). In this case, don't error (which is what currently is done with an undefined error), but instead just go with the default webpack behavior.

I found this by playing around with the sharedPackages key, and forgetting to add requiredVersion...

User-facing changes

Backwards-incompatible changes

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[jtpio]

I found this by playing around with the sharedPackages key, and forgetting to add requiredVersion...

Is the shared package (the one specified in sharedPackages) provided by a federated extension?

Looks like this isn't an issue when the extension is built into jupyterlab (installed from npm), as the requiredVersion would be defaulted here:

jupyterlab/dev_mode/webpack.config.js

Lines 170 to 178 in eb2aa84

	// Add any extension packages that are not in resolutions (i.e., installed from npm)
	for (let pkg of extensionPackages) {
	if (shared[pkg] === undefined) {
	shared[pkg] = {
	requiredVersion: require(`${pkg}/package.json`).version,
	eager: true
	};
	}
	}

[jasongrout]

Looks like this isn't an issue when the extension is built into jupyterlab (installed from npm), as the requiredVersion would be defaulted here:

I triggered it by installing an extension (not federated) that had a sharedPackages override, and I forgot to put a requiredVersion key in. In other words, from

jupyterlab/dev_mode/webpack.config.js

Line 205 in eb2aa84

pkgShared[pkg] = config;

[jasongrout]

Rebased on master to hopefully fix the tests

[blink1073]

Thanks!