-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sourcemaps back to original TS #76
Comments
I've researched this and the related issues extensively. This will require two things:
|
I agree with adding |
"src" is already included in the packages (I didn't think it got removed?): https://github.com/jupyterlab/lumino/blob/master/packages/widgets/package.json#L23 Unless I missed some by mistake? |
Also if you look in the map files you should see that the bundled versions map back to the ts files in question: https://cdn.jsdelivr.net/npm/@lumino/widgets@1.13.2/dist/index.js.map |
I don't see
|
Its there in the released package: https://cdn.jsdelivr.net/npm/@lumino/coreutils@1.5.2/package.json |
If your using WebPack to build your project and your including JS files which in turn already have a source map associated with them (like from TS) then you should be using Example here: https://github.com/GordonSmith/HPCC-Platform/blob/eclwatch-8.x/esp/src/webpack.config.js#L95-L99 |
You might need to change the "devTool" for non production builds as well: https://github.com/GordonSmith/HPCC-Platform/blob/eclwatch-8.x/esp/src/webpack.config.js#L111 (not 100% sure) |
When debugging in JupyterLab (with the UMD bundles introduced in #40), I am seeing the ES6 bundle, we should be able to reach back to the original TS source files:
The text was updated successfully, but these errors were encountered: