Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @jupyterlab/attachments to the build #1021

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 23, 2023

References

Fixes #1020

Code changes

Add @jupyterlab/attachments so it ends up in the resolutions and the webpack shared scope.

User-facing changes

This should prevent some JupyterLab extensions depending on the @jupyterlab/attachments package to fail to activate. For example jupyterlab-myst:

image

Backwards-incompatible changes

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl
Copy link
Collaborator

bollwyvl commented Mar 23, 2023 via email

@jtpio jtpio marked this pull request as ready for review March 24, 2023 08:13
@jtpio jtpio merged commit 87b3c08 into jupyterlite:main Mar 24, 2023
@jtpio jtpio deleted the attachment-package branch March 24, 2023 08:13
@jtpio
Copy link
Member Author

jtpio commented Mar 24, 2023

As noted before: adding a test that compares all the upstream pins/singletons with ours (plus a known list of do-not-wants) would help catch this, and is likely appropriate on this pr.

Opened #1022 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding custom extension to the demo site does not seem to include/activate it
2 participants