Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes #354

Merged
merged 4 commits into from Sep 29, 2021
Merged

Translation fixes #354

merged 4 commits into from Sep 29, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 28, 2021

References

Follow-up to #336

Code changes

User-facing changes

Some minor UX improvements

Backwards-incompatible changes

None

@jtpio jtpio added the bug Something isn't working label Sep 28, 2021
@jtpio
Copy link
Member Author

jtpio commented Sep 28, 2021

5dd5653 tries to work around the current logic in the upstream @jupyterlab/translation plugin that handles the command state (toggled / not toggled):

default-language.mp4

https://github.com/jupyterlab/jupyterlab/blob/befa831ffef36321b87f352a48fbe2439df6c872/packages/translation-extension/src/index.ts#L117

@jtpio jtpio marked this pull request as ready for review September 28, 2021 13:15
@jtpio jtpio merged commit 8126150 into jupyterlite:main Sep 29, 2021
@jtpio jtpio deleted the fix-translations branch September 29, 2021 08:51
@jtpio jtpio added this to the 0.1.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

English option disabled in the language menu
1 participant