fix: HS-183: ApplePay Payment Request to take client's country in case session sends null #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e session sends null
prafulkoppalkar
previously approved these changes
Dec 21, 2023
vsrivatsa-juspay
previously approved these changes
Dec 21, 2023
ArushKapoorJuspay
requested changes
Dec 21, 2023
src/Types/ApplePayTypes.res
Outdated
| @@ -60,7 +64,7 @@ let jsonToPaymentRequestDataType: Js.Dict.t<Js.Json.t> => paymentRequestData = j | |||
| if Utils.getString(jsonDict, "merchant_identifier", "") == "" { | |||
| paymentRequestData( | |||
| ~countryCode=Utils.getString(jsonDict, "country_code", ""), | |||
| ~currencyCode=Utils.getString(jsonDict, "currency_code", ""), | |||
| ~currencyCode=Utils.getString(jsonDict, "currency_code", defaultCountryCode), | |||
There was a problem hiding this comment.
Why is defaultCountryCode added for currency_code?
arun-mi
dismissed stale reviews from vsrivatsa-juspay and prafulkoppalkar
via
1eb12a2
ArushKapoorJuspay
approved these changes
Dec 21, 2023
vsrivatsa-juspay
approved these changes
Dec 21, 2023
akash-c-k
pushed a commit
that referenced
this pull request
Dec 21, 2023
## [0.16.3](v0.16.2...v0.16.3) (2023-12-21) ### Bug Fixes * HS-183: ApplePay Payment Request to take client's country in case session sends null ([#78](#78)) ([2ee7afc](2ee7afc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In new flow it is possible for BE to not know what the country code will be. In such scenarios where Client has to send a country, we are setting the country as client's country by default.