Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [Forte] Remove Default Case Handling #2270

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 7 comments · Fixed by #2625
Closed
2 tasks done

[REFACTOR]: [Forte] Remove Default Case Handling #2270

Sakilmostak opened this issue Sep 22, 2023 · 7 comments · Fixed by #2625
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
  • These conditions generally go hand in hand with enum variants.
  • Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
  • So, if all the explicit cases are handled then default is used to handle the rest.
  • Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
  • This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

🔨 Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@SatnamSingh65
Copy link

Hi there
I would like to work on this issue. Please assign it to me.
Thanks

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 5, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @SatnamSingh10, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@VedantKhairnar
Copy link
Contributor

Hey @SatnamSingh10 ,
Let us know if you face any issues. Happy to help! : )

@swangi-kumari
Copy link
Contributor

Hello @SatnamSingh10 , we didn't hear back from you, so we are unassigning you from this issue. If you are interested, we will assign you with other issues, if the current one is taken.

@swangi-kumari swangi-kumari added the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 17, 2023
@SagarDevAchar
Copy link
Contributor

Hey, I'd like to work on this!
I completed working on Issue #2223 and waiting for PR #2615 to be merged

@swangi-kumari
Copy link
Contributor

Hey @SagarDevAchar, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with.

@swangi-kumari swangi-kumari removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 18, 2023
@swangi-kumari swangi-kumari added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 19, 2023
@swangi-kumari
Copy link
Contributor

This issue has already been resolved in this pr 2625, So I am closing this.

@SanchithHegde SanchithHegde linked a pull request Oct 19, 2023 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants