Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [Opayo] Remove Default Case Handling #2279

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 15 comments · Fixed by #2687
Closed
2 tasks done

[REFACTOR]: [Opayo] Remove Default Case Handling #2279

Sakilmostak opened this issue Sep 22, 2023 · 15 comments · Fixed by #2687
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
  • These conditions generally go hand in hand with enum variants.
  • Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
  • So, if all the explicit cases are handled then default is used to handle the rest.
  • Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
  • This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

🔨 Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Abhiramjampani
Copy link

@AkshayaFoiger @Sakilmostak @VedantKhairnar
I would be delighted to work on this issue
so kindly assign me this issue
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @Abhiramjampani , I see that you're already assigned to #2346. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2346 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@amaan14999
Copy link
Contributor

Hi @AkshayaFoiger. I would be delighted to work on this issue. My previous PR is under review and in merging process.

@Sakilmostak Sakilmostak removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 10, 2023
@Sakilmostak
Copy link
Contributor Author

Hello @amaan14999 , thanks for the submission. I have assigned this issue to you👍

@amaan14999
Copy link
Contributor

Hey @Sakilmostak, thanks for the update but the issue has not yet been assigned to me.

@amaan14999
Copy link
Contributor

@Sakilmostak @VedantKhairnar @AkshayaFoiger can this issue be please assigned to me?

@SanchithHegde
Copy link
Member

@amaan14999 Done, sorry about the confusion.

@swangi-kumari
Copy link
Contributor

Hello @amaan14999 ,
Are you still working on this issue?
Please let us know if you need any help:)

@Hangsaai
Copy link
Contributor

Hangsaai commented Oct 24, 2023

Hey @swangi-kumari can you assign this to me as I have already raised a PR and want to work on this

@amaan14999
Copy link
Contributor

Hey @swangi-kumari, I tried but was not able to resolve the issue since I am new to Rust. Kindly unassign me.

@swangi-kumari
Copy link
Contributor

Hey @swangi-kumari, I tried but was not able to resolve the issue since I am new to Rust. Kindly unassign me.

Sure, Glad that you tried:)

@swangi-kumari swangi-kumari added the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 24, 2023
@HeetVekariya
Copy link
Contributor

@swangi-kumari can you please assign me this issue, as i have worked on the similar issues.

@deepanshu-iiitu
Copy link
Contributor

Hey @Hangsaai , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@deepanshu-iiitu
Copy link
Contributor

deepanshu-iiitu commented Oct 25, 2023

@swangi-kumari can you please assign me this issue, as i have worked on the similar issues.

Hey @HeetVekariya ,
Actually we assign the issue on FCF basis. If you are interested you can pick some other open issues.

@deepanshu-iiitu deepanshu-iiitu removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 25, 2023
@HeetVekariya
Copy link
Contributor

@swangi-kumari can you please assign me this issue, as i have worked on the similar issues.

Hey @HeetVekariya ,
Actually we assign the issue on FCF basis. If you are interested you can pick some other open issues.

No worries, I haven't seen that comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants