Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement PayoutsInterface for MockDb #4150

Open
2 tasks done
Tracked by #172
kashif-m opened this issue Mar 20, 2024 · 3 comments
Open
2 tasks done
Tracked by #172

[FEATURE] Implement PayoutsInterface for MockDb #4150

kashif-m opened this issue Mar 20, 2024 · 3 comments
Assignees
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kashif-m
Copy link
Contributor

kashif-m commented Mar 20, 2024

Feature Description

MockDb allows consumers to run hyperswitch without psql. This needs to be added for payout tables - payouts and payout_attempt

Possible Implementation

Similar to how it's being done for other tables.

See #172 for more information.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@kashif-m kashif-m added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet labels Mar 20, 2024
@SanchithHegde SanchithHegde added A-framework Area: Framework good first issue Good for newcomers help wanted Extra attention is needed and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Mar 31, 2024
@SanchithHegde SanchithHegde changed the title [FEATURE] Implement MockDb for payouts [FEATURE] Implement PayoutsInterface for MockDb Mar 31, 2024
@srini047
Copy link

srini047 commented Apr 9, 2024

Hi @SanchithHegde, I would like to work on this issue.

But, I already see a existing implementation here. Is there anything more specific I need to target or am I completely wrong.

I am newbie here glad to get assisted further to kickstart my first contribution.

@SanchithHegde
Copy link
Member

Hey @srini047, you've correctly identified the PayoutsInterface implementaion on MockDb, but if you notice, all of the methods in the implementation return an error, because the Rust type system enforces us to provide a placeholder implementation.

As part of this issue, you are required to update the MockDb implementation to behave similar to the implementation which uses the database (you can find the implementation here). The database implementation is simple, for say, inserts or updates, while being slightly more complex for queries that involve filtering. You'd have to write the MockDb implementation accordingly.

I would like to work on this issue.

Sure, I'll assign it to you.

@srini047
Copy link

@SanchithHegde Sorry for the delay. I was new to rust and it took time for me to understand the codebase and traits especially. With time I learnt a lot and now I feel ready to implement. Will make a PR real soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants